Re: [Qemu-devel] [RFC PATCH] hw/arm/virt: Added preliminary GICv3 support for kvm mode

[Pavel Fedin]

 Hello!

> Added -M virt,gicversion=2,3 property to configure GICv2 or GICv3.
> GICv3 save/restore is not supported as vgic-v3-emul.c is yet to support
> them.
> 
> Signed-off-by: Ashok Kumar <address@hidden>

 I also work on this, just not published yet. Some notes about your version:
1. May be there should be hw/intc/arm_gicv3_kvm.c file created for GICv3? As 
far as i can
see, save/restore code should differ a lot.
2. kvm_arch_irqchip_create() should probe only for type we want to get. It has 
to be
passed there somehow from the virt machine initializer. And, if we want GICv3, 
then upon
failure it should return error, not zero. This is because when 
kvm_arch_irqchip_create()
returns zero, a fallback code is used, which will create GICv2.
3. Perhaps you should base your work on these patch sets:
    https://lists.gnu.org/archive/html/qemu-devel/2015-05/msg00941.html
    https://lists.gnu.org/archive/html/qemu-devel/2015-05/msg01505.html

 I added Shlomo to cc because he might also be interested.

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia