[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH] hw/arm/virt: Added preliminary GICv3 suppor
Re: [Qemu-devel] [RFC PATCH] hw/arm/virt: Added preliminary GICv3 support for kvm mode
Fri, 15 May 2015 09:42:40 +0300
> Added -M virt,gicversion=2,3 property to configure GICv2 or GICv3.
> GICv3 save/restore is not supported as vgic-v3-emul.c is yet to support
> Signed-off-by: Ashok Kumar <address@hidden>
I also work on this, just not published yet. Some notes about your version:
1. May be there should be hw/intc/arm_gicv3_kvm.c file created for GICv3? As
far as i can
see, save/restore code should differ a lot.
2. kvm_arch_irqchip_create() should probe only for type we want to get. It has
passed there somehow from the virt machine initializer. And, if we want GICv3,
failure it should return error, not zero. This is because when
returns zero, a fallback code is used, which will create GICv2.
3. Perhaps you should base your work on these patch sets:
I added Shlomo to cc because he might also be interested.
Samsung Electronics Research center Russia
Re: [Qemu-devel] [RFC PATCH] hw/arm/virt: Added preliminary GICv3 support for kvm mode, Eric Auger, 2015/05/19
Re: [Qemu-devel] [RFC PATCH] hw/arm/virt: Added preliminary GICv3 support for kvm mode, Eric Auger, 2015/05/18