[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 20/22] hw/acpi/aml-build: Add Unicode macro
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH v6 20/22] hw/acpi/aml-build: Add Unicode macro |
Date: |
Fri, 15 May 2015 16:13:26 +0200 |
On Thu, 7 May 2015 17:29:22 +0800
Shannon Zhao <address@hidden> wrote:
> From: Shannon Zhao <address@hidden>
>
> Signed-off-by: Shannon Zhao <address@hidden>
> Signed-off-by: Shannon Zhao <address@hidden>
> ---
> hw/acpi/aml-build.c | 18 ++++++++++++++++++
> include/hw/acpi/aml-build.h | 1 +
> 2 files changed, 19 insertions(+)
>
> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
> index 67b7719..06f9d37 100644
> --- a/hw/acpi/aml-build.c
> +++ b/hw/acpi/aml-build.c
> @@ -1061,6 +1061,24 @@ Aml *aml_touuid(const char *uuid)
> return var;
> }
>
> +/*
> + * ACPI 2.0b: 16.2.3.6.4.3 Unicode Macro (Convert Ascii String To Unicode)
> + */
> +Aml *aml_unicode(const char *str)
> +{
> + Aml *var = aml_bundle(0x11 /* BufferOp */, AML_BUFFER);
> +
> + while (*str != '\0') {
{
> + build_append_byte(var->buf, 0);
> + build_append_byte(var->buf, *str);
order seems to be wrong, shouldn't you swap bytes?
> + str++;
> + }
} while(*str != '\0');
and drop vvv
> + build_append_byte(var->buf, 0);
> + build_append_byte(var->buf, *str);
> +
> + return var;
> +}
> +
> void
> build_header(GArray *linker, GArray *table_data,
> AcpiTableHeader *h, const char *sig, int len, uint8_t rev)
> diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h
> index 5ff9c14..39b44e4 100644
> --- a/include/hw/acpi/aml-build.h
> +++ b/include/hw/acpi/aml-build.h
> @@ -269,6 +269,7 @@ Aml *aml_field(const char *name, AmlFieldFlags flags);
> Aml *aml_create_dword_field(Aml *srcbuf, Aml *index, const char *name);
> Aml *aml_varpackage(uint32_t num_elements);
> Aml *aml_touuid(const char *uuid);
> +Aml *aml_unicode(const char *str);
>
> void
> build_header(GArray *linker, GArray *table_data,
- [Qemu-devel] [PATCH v6 01/22] hw/i386: Move ACPI header definitions in an arch-independent location, (continued)
- [Qemu-devel] [PATCH v6 01/22] hw/i386: Move ACPI header definitions in an arch-independent location, Shannon Zhao, 2015/05/07
- [Qemu-devel] [PATCH v6 16/22] hw/acpi/aml-build: Add aml_lnot() term, Shannon Zhao, 2015/05/07
- [Qemu-devel] [PATCH v6 12/22] hw/arm/virt-acpi-build: Add PCIe info and generate MCFG table, Shannon Zhao, 2015/05/07
- [Qemu-devel] [PATCH v6 15/22] hw/acpi/aml-build: Add aml_or() term, Shannon Zhao, 2015/05/07
- [Qemu-devel] [PATCH v6 14/22] hw/acpi/aml-build: Add ToUUID macro, Shannon Zhao, 2015/05/07
- [Qemu-devel] [PATCH v6 10/22] hw/arm/virt-acpi-build: Generate RSDT table, Shannon Zhao, 2015/05/07
- [Qemu-devel] [PATCH v6 20/22] hw/acpi/aml-build: Add Unicode macro, Shannon Zhao, 2015/05/07
- Re: [Qemu-devel] [PATCH v6 20/22] hw/acpi/aml-build: Add Unicode macro,
Igor Mammedov <=
- [Qemu-devel] [PATCH v6 18/22] hw/acpi/aml-build: Add aml_create_dword_field() term, Shannon Zhao, 2015/05/07
- [Qemu-devel] [PATCH v6 19/22] hw/acpi/aml-build: Add aml_dword_io() term, Shannon Zhao, 2015/05/07
- [Qemu-devel] [PATCH v6 11/22] hw/arm/virt-acpi-build: Generate RSDP table, Shannon Zhao, 2015/05/07
- [Qemu-devel] [PATCH v6 13/22] hw/acpi/aml-build: Make aml_buffer() definition consistent with the spec, Shannon Zhao, 2015/05/07
- [Qemu-devel] [PATCH v6 17/22] hw/acpi/aml-build: Add aml_else() term, Shannon Zhao, 2015/05/07