[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH v3 03/10] block: rename BlkTransact
Re: [Qemu-devel] [Qemu-block] [PATCH v3 03/10] block: rename BlkTransactionState and BdrvActionOps
Mon, 18 May 2015 13:23:31 +0100
On Wed, Apr 22, 2015 at 08:04:46PM -0400, John Snow wrote:
> These structures are misnomers, somewhat.
> (1) BlockTransactionState is not state for a transaction,
> but is rather state for a single transaction action.
> Rename it "BlkActionState" to be more accurate.
> (2) The BdrvActionOps describes operations for the BlkActionState,
> above. This name might imply a 'BdrvAction' or a 'BdrvActionState',
> which there isn't.
> Rename this to 'BlkActionOps' to match 'BlkActionState'.
> Lastly, update the surrounding in-line documentation and comments
> to reflect the current nature of how Transactions operate.
> This patch changes only comments and names, and should not affect
> behavior in any way.
> Signed-off-by: John Snow <address@hidden>
> Reviewed-by: Max Reitz <address@hidden>
> blockdev.c | 114
> 1 file changed, 64 insertions(+), 50 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
Description: PGP signature
|[Prev in Thread]
||[Next in Thread]|
- Re: [Qemu-devel] [Qemu-block] [PATCH v3 03/10] block: rename BlkTransactionState and BdrvActionOps,
Stefan Hajnoczi <=