[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/9] runstate: create runstate_index function
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 4/9] runstate: create runstate_index function |
Date: |
Mon, 18 May 2015 08:55:04 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 05/18/2015 03:58 AM, Dr. David Alan Gilbert wrote:
> * Juan Quintela (address@hidden) wrote:
>> Given a string state, we need a way to get the RunState for that string.
>>
>> Signed-off-by: Juan Quintela <address@hidden>
>> ---
>> include/sysemu/sysemu.h | 1 +
>> vl.c | 13 +++++++++++++
>> 2 files changed, 14 insertions(+)
>>
>>
>> +RunState runstate_index(char *str)
>> +{
>> + RunState i = 0;
>> +
>> + while (i != RUN_STATE_MAX) {
>> + if (strcmp(str, RunState_lookup[i]) == 0) {
>> + return i;
>> + }
>> + i++;
>> + }
>> + return -1;
>
> It doesn't seem right to return -1 for the value of an enum
> (which is otherwise used as an index into an array of strings).
>
> Make it return a bool and pass the RunState* as a parameter ?
Why open-code this, when we already have qapi_enum_parse() in
qapi/qapi-util.c?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/9] Optional toplevel sections, Juan Quintela, 2015/05/14
- [Qemu-devel] [PATCH 3/9] runstate: Add runstate store, Juan Quintela, 2015/05/14
- [Qemu-devel] [PATCH 4/9] runstate: create runstate_index function, Juan Quintela, 2015/05/14
- [Qemu-devel] [PATCH 5/9] runstate: migration allows more transitions now, Juan Quintela, 2015/05/14
- [Qemu-devel] [PATCH 1/9] migration: create savevm_state, Juan Quintela, 2015/05/14
- [Qemu-devel] [PATCH 6/9] migration: create new section to store global state, Juan Quintela, 2015/05/14
- [Qemu-devel] [PATCH 7/9] global_state: Make section optional, Juan Quintela, 2015/05/14
- [Qemu-devel] [PATCH 8/9] vmstate: Create optional sections, Juan Quintela, 2015/05/14