[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] block: get_block_status: use "else" when testin
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH] block: get_block_status: use "else" when testing the opposite condition |
Date: |
Tue, 19 May 2015 11:49:19 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, May 14, 2015 at 12:35:02PM +0200, Paolo Bonzini wrote:
> A bit of Boolean algebra (and common sense) tells us that the
> second "if" here is looking for blocks that are not allocated.
> This is the opposite of the "if" that sets BDRV_BLOCK_ALLOCATED,
> and thus it can use an "else".
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> block/io.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
pgpKPKn4o2F00.pgp
Description: PGP signature