[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 2/4] apic: convert ->busdev.qdev casts to C c
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH v6 2/4] apic: convert ->busdev.qdev casts to C casts |
Date: |
Wed, 20 May 2015 13:48:40 +0200 |
On Wed, 20 May 2015 10:40:47 +0800
Zhu Guihua <address@hidden> wrote:
> Use C casts to avoid accessing ICCDevice's qdev field
> directly.
>
> Signed-off-by: Zhu Guihua <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
> ---
> hw/intc/apic.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/hw/intc/apic.c b/hw/intc/apic.c
> index 0f97b47..77b639c 100644
> --- a/hw/intc/apic.c
> +++ b/hw/intc/apic.c
> @@ -370,13 +370,14 @@ static int apic_irq_pending(APICCommonState *s)
> static void apic_update_irq(APICCommonState *s)
> {
> CPUState *cpu;
> + DeviceState *dev = (DeviceState *)s;
>
> cpu = CPU(s->cpu);
> if (!qemu_cpu_is_self(cpu)) {
> cpu_interrupt(cpu, CPU_INTERRUPT_POLL);
> } else if (apic_irq_pending(s) > 0) {
> cpu_interrupt(cpu, CPU_INTERRUPT_HARD);
> - } else if (!apic_accept_pic_intr(&s->busdev.qdev) ||
> !pic_get_output(isa_pic)) {
> + } else if (!apic_accept_pic_intr(dev) || !pic_get_output(isa_pic)) {
> cpu_reset_interrupt(cpu, CPU_INTERRUPT_HARD);
> }
> }
> @@ -549,10 +550,12 @@ static void apic_deliver(DeviceState *dev, uint8_t
> dest, uint8_t dest_mode,
>
> static bool apic_check_pic(APICCommonState *s)
> {
> - if (!apic_accept_pic_intr(&s->busdev.qdev) || !pic_get_output(isa_pic)) {
> + DeviceState *dev = (DeviceState *)s;
> +
> + if (!apic_accept_pic_intr(dev) || !pic_get_output(isa_pic)) {
> return false;
> }
> - apic_deliver_pic_intr(&s->busdev.qdev, 1);
> + apic_deliver_pic_intr(dev, 1);
> return true;
> }
>
[Qemu-devel] [PATCH v6 4/4] icc_bus: drop the unused files, Zhu Guihua, 2015/05/19
[Qemu-devel] [PATCH v6 3/4] cpu/apic: drop icc bus/bridge, Zhu Guihua, 2015/05/19