Re: [Qemu-devel] [PATCH v8 02/24] hw/arm/virt: Move common definitions to virt.h

[Peter Maydell]

On 21 May 2015 at 09:25, Igor Mammedov <address@hidden> wrote:
> On Thu, 21 May 2015 10:28:29 +0800
> Shannon Zhao <address@hidden> wrote:
>> --- /dev/null
>> +++ b/include/hw/arm/virt.h
>> @@ -0,0 +1,56 @@
>> +/*
>> + *
>> + * Copyright (c) 2015 Linaro Limited
> out of curiosity, git blame - tells that moved code was authored by:
> Laszlo Ersek
> Alexander Graf
> Peter Maydell
> shouldn't they be mentioned here as authors?

Copyright headers are weird things, they don't really fit
well with the "lots of contributors" open source model anyway.
Mostly new files tend to get a copy of the header from the
file the code was moved from, which is what's happened here.

That said, Laszlo and Alex contributed one line each (extra
entries in the enum) and I wrote the rest, and my code is
copyright Linaro anyway. So I think it's fine.

-- PMM