Re: [Qemu-devel] [PATCH 03/10] target-tricore: Add SRC_MOV_E instruction of the v1.6 ISA

[Richard Henderson]

On 05/13/2015 02:45 AM, Bastian Koppelmann wrote:
> Signed-off-by: Bastian Koppelmann <address@hidden>
> ---
>  target-tricore/translate.c | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>

> +    case OPC1_16_SRC_MOV_E:
> +        if (tricore_feature(env, TRICORE_FEATURE_16)) {
> +            tcg_gen_movi_tl(cpu_gpr_d[r1], const4);
> +            tcg_gen_sari_tl(cpu_gpr_d[r1+1], cpu_gpr_d[r1], 31);

You could sign-extend here at translation time, but it's also true that the
optimizer will handle this.


r~