[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] vhost-user: add multi queue support
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3] vhost-user: add multi queue support |
Date: |
Thu, 21 May 2015 13:03:26 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 05/21/2015 08:20 AM, Ouyang Changchun wrote:
> From: Changchun Ouyang <address@hidden>
>
It's better to post a v3 patch as a new top-level thread, rather than
in-reply-to an existing thread.
> Based on patch by Nikolay Nikolaev:
> Vhost-user will implement the multi queue support in a similar way
> to what vhost already has - a separate thread for each queue.
> To enable the multi queue funcionality - a new command line parameter
s/funcionality/functionality/
> "queues" is introduced for the vhost-user netdev.
>
> Signed-off-by: Nikolay Nikolaev <address@hidden>
> Signed-off-by: Changchun Ouyang <address@hidden>
> ---
> Changes since v2:
> - fix vq index issue for set_vring_call
> When it is the case of VHOST_SET_VRING_CALL, The vq_index is not
> initialized before it is used,
> thus it could be a random value. The random value lead to crash in vhost
> after passing down
> to vhost, as vhost use this random value to index an array index.
> - fix the typo in the doc and description
> - address vq index for reset_owner
> +++ b/qapi-schema.json
> @@ -2444,12 +2444,16 @@
> #
> # @vhostforce: #optional vhost on for non-MSIX virtio guests (default:
> false).
> #
> +# @queues: #optional number of queues to be created for multiqueue
> vhost-user (default: 1).
Long line; please wrap to fit under 80 columns.
> +# (Since 2.4)
> +#
> # Since 2.1
> ##
> { 'struct': 'NetdevVhostUserOptions',
> 'data': {
> 'chardev': 'str',
> - '*vhostforce': 'bool' } }
> + '*vhostforce': 'bool',
> + '*queues': 'uint32' } }
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature