[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 15/20] monitor: Rename monitor_control_read(), m
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 15/20] monitor: Rename monitor_control_read(), monitor_control_event() |
Date: |
Fri, 22 May 2015 16:46:30 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 05/22/2015 05:36 AM, Markus Armbruster wrote:
> ... to monitor_qmp_read(), monitor_qmp_event().
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> monitor.c | 14 ++++----------
> 1 file changed, 4 insertions(+), 10 deletions(-)
Not a trivial rename based on diffstat, but...
>
> diff --git a/monitor.c b/monitor.c
> index ecadda7..977c0fd 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -5043,10 +5043,7 @@ err_out:
> QDECREF(args);
> }
>
> -/**
> - * monitor_control_read(): Read and handle QMP input
> - */
> -static void monitor_control_read(void *opaque, const uint8_t *buf, int size)
> +static void monitor_qmp_read(void *opaque, const uint8_t *buf, int size)
Drops a comment, but the comment didn't add much.
> {
> Monitor *old_mon = cur_mon;
>
> @@ -5111,10 +5108,7 @@ static QObject *get_qmp_greeting(void)
> return qobject_from_jsonf("{'QMP':{'version': %p,'capabilities':
> []}}",ver);
> }
>
> -/**
> - * monitor_control_event(): Print QMP gretting
> - */
> -static void monitor_control_event(void *opaque, int event)
> +static void monitor_qmp_event(void *opaque, int event)
Drops a typo in the otherwise useless comment. (I'm surprised numerous
scans for spelling cleanups haven't yet flagged "gretting" as unusual).
...so I'm okay with it.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 19/20] monitor: Rename monitor_ctrl_mode() to monitor_is_qmp(), (continued)
- [Qemu-devel] [PATCH 13/20] monitor: Limit QError use to command handlers, Markus Armbruster, 2015/05/22
- [Qemu-devel] [PATCH 16/20] monitor: Unbox Monitor member mc and rename to qmp, Markus Armbruster, 2015/05/22
- [Qemu-devel] [PATCH 11/20] monitor: Wean monitor_protocol_emitter() off mon->error, Markus Armbruster, 2015/05/22
- [Qemu-devel] [PATCH 15/20] monitor: Rename monitor_control_read(), monitor_control_event(), Markus Armbruster, 2015/05/22
- Re: [Qemu-devel] [PATCH 15/20] monitor: Rename monitor_control_read(), monitor_control_event(),
Eric Blake <=
- [Qemu-devel] [PATCH 20/20] monitor: Change return type of monitor_cur_is_qmp() to bool, Markus Armbruster, 2015/05/22