Re: [Qemu-devel] [PATCH v2 4/7] disas: arm: QOMify target specific disas setup

[Peter Crosthwaite]

On Mon, May 18, 2015 at 9:31 AM, Peter Maydell <address@hidden> wrote:
> On 9 May 2015 at 21:11, Peter Crosthwaite <address@hidden> wrote:
>> Move the target_disas() ARM specifics to the QOM disas_set_info hook

>>
>> +static int
>> +print_insn_thumb1(bfd_vma pc, disassemble_info *info)
>> +{
>> +  return print_insn_arm(pc | 1, info);
>> +}
>> +
>> +static void arm_disas_set_info(CPUState *cpu, disassemble_info *info)
>> +{
>> +    ARMCPU *ac = ARM_CPU(cpu);
>> +    CPUARMState *env = &ac->env;
>> +
>> +    if (env->aarch64) {
>
> if (is_a64(env)) please.

Fixed.

> (At some point I'm likely to tidy up handling of A64 pstate,
> and maybe this flag will disappear back into the uncached pstate.)
>
> Otherwise
> Reviewed-by: Peter Maydell <address@hidden>
>

Thanks.

Regards,
Peter

> thanks
> -- PMM
>