Re: [Qemu-devel] [PATCH 07/10] target-s390x: enable fully implemented facilities

[Alexander Graf]

On 25.05.15 23:02, Aurelien Jarno wrote:
> On 2015-05-25 22:39, Alexander Graf wrote:
>>
>>
>> On 25.05.15 01:47, Aurelien Jarno wrote:
>>> Cc: Alexander Graf <address@hidden>
>>> Cc: Richard Henderson <address@hidden>
>>> Signed-off-by: Aurelien Jarno <address@hidden>
>>
>> Shouldn't this get populated based on the selected -cpu type?
> 
> In the long term yes, but given we only implement one CPU type (or
> rather none) in TCG mode, we can consider that's already the case.

There are patches coming from IBM to at least add a list of a good
number of s390x cpu types. I'd really like to make use of that and have
actual CPU types selectable.

At least let's move towards that model. So the code in question should
take the facility capabilities from the first cpu object (or the class?)
for example and we bump it to the currently supported feature set in there.


Alex