[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 3/4] spapr_pci: enumerate and add PCI device
Re: [Qemu-devel] [PATCH v5 3/4] spapr_pci: enumerate and add PCI device tree
Tue, 26 May 2015 10:34:26 +1000
On Mon, May 25, 2015 at 03:53:52PM +0530, Nikunj A Dadhania wrote:
> Alexey Kardashevskiy <address@hidden> writes:
> > On 05/25/2015 02:45 PM, Nikunj A Dadhania wrote:
> >> Alexey Kardashevskiy <address@hidden> writes:
> >>> Can we also add a hack here to scan for the "qemu,phb-enumerated" string
> >>> in
> >>> the SLOF bin image?
> >> Really ? That would be ugly.
> > Well, chances that the binary image will have this line by accident are
> > zero.
> > And I spent quite some time debugging SRIOV + VFIO when I realized that
> > SLOF is old on the test machine where others used to debug too. It would be
> > really nice to have a warning that something is wrong. May be extend
> > "client-architecture-support" somehow or have some release/date signature
> > in known place in SLOF... Thomas (?) also asked for this :)
> Sure, I can work on this. I would not recommend grepping though.
Yeah, don't do this. The ugliness is not worth it.
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
Description: PGP signature
[Qemu-devel] [PATCH v5 4/4] spapr_pci: populate ibm,loc-code, Nikunj A Dadhania, 2015/05/19
[Qemu-devel] [PATCH v5 2/4] spapr_pci: encode class code including Prog IF register, Nikunj A Dadhania, 2015/05/19
[Qemu-devel] [PATCH v5 1/4] spapr_pci: encode missing 64-bit memory address space, Nikunj A Dadhania, 2015/05/19