[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/4] More core code ENV_GET_CPU removals

From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH 0/4] More core code ENV_GET_CPU removals
Date: Tue, 26 May 2015 08:10:56 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0

Am 25.05.2015 um 15:08 schrieb Paolo Bonzini:
> On 25/05/2015 08:22, Peter Crosthwaite wrote:
>> Hi Andreas, Richard and all,
>> I'm moving towards the goal of having no core code usages of ENV_GET_CPU.
>> This has two advantages:
>> 1: It means we are closer to common-obj'ing core code like exec.c, cpus.c
>> and friends.
>> 2: Multi arch is easier if ENV_GET_CPU stays arch specific. It means I
>> don't need those patches where I reorder the env within the arch specific
>> CPUState. This allows continuing placement of arch specifics before the
>> env in the CPU container (which has TCG perf advantages).
>> There's a couple more after this pack to get the multi-arch thing going,
>> but due to point 1, I'm sending this ahead as I think it has standalone 
>> value.
>> Regards,
>> Peter
>> Peter Crosthwaite (4):
>>   translate-all: Change tb_flush env argument to cpu
>>   gdbserver: _fork: Change fn to accept cpu instead of env
>>   cpus: Change tcg_cpu_exec arg to cpu, not env
>>   cpus: Change exec_init arg to cpu, not env
> Thanks, queued for 2.4.

Apparently after qom-next you also want to take over qom-cpu, once again
without pinging me first. Then make it official in MAINTAINERS and
really review the patches line by line rather than just queuing them
somewhere (again you didn't bother to state where). It can't go on like
this and I'll be on vacation soon anyway.

Do you want to take over PReP too while you're at it?


SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB
21284 (AG Nürnberg)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]