[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 08/29] ui/console: remove dpy_gfx_update_dirty

From: Fam Zheng
Subject: Re: [Qemu-devel] [PATCH 08/29] ui/console: remove dpy_gfx_update_dirty
Date: Tue, 26 May 2015 16:03:04 +0800
User-agent: Mutt/1.5.23 (2014-03-12)

On Mon, 04/27 18:28, Paolo Bonzini wrote:
> dpy_gfx_update_dirty expects DIRTY_MEMORY_VGA logging to be always on,
> but that will not be the case soon.  Because it computes the memory
> region on the fly for every update (with memory_region_find), it cannot
> enable/disable logging by itself.
> We could always treat updates as invalidations if dirty logging is
> not enabled, assuming that the board will enable logging on the
> RAM region that includes the framebuffer.
> However, the function is unused, so just drop it.
> Signed-off-by: Paolo Bonzini <address@hidden>

Reviewed-by: Fam Zheng <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]