[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 23/29] bitmap: add atomic set functions
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 23/29] bitmap: add atomic set functions |
|
Date: |
Tue, 26 May 2015 13:58:25 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 26/05/2015 13:54, Fam Zheng wrote:
> > +void bitmap_set_atomic(unsigned long *map, long start, long nr)
> > +{
> > + unsigned long *p = map + BIT_WORD(start);
> > + const long size = start + nr;
>
> s/size/end/ ?
That is consistent with bitmap_set, but we could consider changing it
there too.
Paolo
> Otherwise,
>
> Reviewed-by: Fam Zheng <address@hidden>
>