[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 27/29] memory: replace cpu_physical_memory_reset
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 27/29] memory: replace cpu_physical_memory_reset_dirty() with test-and-clear |
|
Date: |
Tue, 26 May 2015 14:45:54 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 26/05/2015 14:42, Fam Zheng wrote:
>> > {
>> > - cpu_physical_memory_clear_dirty_range_type(start, length,
>> > DIRTY_MEMORY_MIGRATION);
>> > - cpu_physical_memory_clear_dirty_range_type(start, length,
>> > DIRTY_MEMORY_VGA);
>> > - cpu_physical_memory_clear_dirty_range_type(start, length,
>> > DIRTY_MEMORY_CODE);
>> > + cpu_physical_memory_test_and_clear_dirty(start, length,
>> > DIRTY_MEMORY_MIGRATION);
> Is this line too long? Otherwise,
Yes, it's 84 characters long. On the other hand, it is shorter than the
existing line...
Paolo
> Reviewed-by: Fam Zheng <address@hidden>
>
>> > + cpu_physical_memory_test_and_clear_dirty(start, length,
>> > DIRTY_MEMORY_VGA);
>> > + cpu_physical_memory_test_and_clear_dirty(start, length,
>> > DIRTY_MEMORY_CODE);
>> > }
>> >