[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/20] monitor: Convert client_migrate_info to Q
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 04/20] monitor: Convert client_migrate_info to QAPI |
Date: |
Tue, 26 May 2015 16:55:33 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Gerd Hoffmann <address@hidden> writes:
> Hi,
>
>> Should we continue to document the command is about "spice/vnc
>> connection info", or should we rephrase? Something like:
>>
>> client_migrate_info
>> -------------------
>>
>> Set remote display connection information for migration. This makes the
>> server ask the client to automatically reconnect using the new
>> parameters once migration finished successfully. Only implemented for
>> SPICE.
>>
>> Arguments:
>>
>> - "protocol": must be "spice" (json-string)
>> - "hostname": migration target hostname (json-string)
>> - "port": spice/vnc tcp port for plaintext channels (json-int,
>> optional)
>> - "tls-port": spice tcp port for tls-secured channels (json-int,
>> optional)
>> - "cert-subject": server certificate subject (json-string, optional)
>
> Looks good to me.
Okay, I'll squash something like that into PATCH 03, and cc: you for
review.
- Re: [Qemu-devel] [PATCH 10/20] monitor: Propagate errors through qmp_check_input_obj(), (continued)
- [Qemu-devel] [PATCH 12/20] monitor: Inline monitor_has_error() into its only caller, Markus Armbruster, 2015/05/22
- [Qemu-devel] [PATCH 04/20] monitor: Convert client_migrate_info to QAPI, Markus Armbruster, 2015/05/22
- Re: [Qemu-devel] [PATCH 04/20] monitor: Convert client_migrate_info to QAPI, Eric Blake, 2015/05/22
- Re: [Qemu-devel] [PATCH 04/20] monitor: Convert client_migrate_info to QAPI, Markus Armbruster, 2015/05/26
- Re: [Qemu-devel] [PATCH 04/20] monitor: Convert client_migrate_info to QAPI, Gerd Hoffmann, 2015/05/26
- Re: [Qemu-devel] [PATCH 04/20] monitor: Convert client_migrate_info to QAPI, Daniel P. Berrange, 2015/05/26
- Re: [Qemu-devel] [PATCH 04/20] monitor: Convert client_migrate_info to QAPI, Markus Armbruster, 2015/05/26
- Re: [Qemu-devel] [PATCH 04/20] monitor: Convert client_migrate_info to QAPI, Gerd Hoffmann, 2015/05/26
- Re: [Qemu-devel] [PATCH 04/20] monitor: Convert client_migrate_info to QAPI,
Markus Armbruster <=
[Qemu-devel] [PATCH 02/20] monitor: Clean up after previous commit, Markus Armbruster, 2015/05/22
[Qemu-devel] [PATCH 17/20] monitor: Drop do_qmp_capabilities()'s superfluous QMP check, Markus Armbruster, 2015/05/22
[Qemu-devel] [PATCH 06/20] monitor: Use traditional command interface for HMP device_add, Markus Armbruster, 2015/05/22
[Qemu-devel] [PATCH 05/20] monitor: Use traditional command interface for HMP drive_del, Markus Armbruster, 2015/05/22
[Qemu-devel] [PATCH 14/20] monitor: Rename handle_user_command() to handle_hmp_command(), Markus Armbruster, 2015/05/22