Re: [Qemu-devel] [PATCH 1/3] qcow2: mark the memory as no longer needed after qcow2_cache_empty()

[Alberto Garcia]

On Tue 26 May 2015 05:39:12 PM CEST, Max Reitz <address@hidden> wrote:

>> After having emptied the cache, the data in the cache tables is no
>> longer useful, so we can tell the kernel that we are done with it. In
>> Linux this frees the resources associated with it.

> Looks good, but by applying the same logic, you could do the same call
> in qcow2_cache_create(). So what about it? :-)

But after qcow2_cache_create() the memory is still unused so this
doesn't have any affect.

> Also note that bdrv_commit() is used only by the HMP commit operation,
> not by QMP commit.

Thanks, I should probably clarify that in the commit message.

Berto