[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] qcow2: mark the memory as no longer needed
Re: [Qemu-devel] [PATCH 1/3] qcow2: mark the memory as no longer needed after qcow2_cache_empty()
Tue, 26 May 2015 17:51:51 +0200
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
On 26.05.2015 17:51, Alberto Garcia wrote:
On Tue 26 May 2015 05:39:12 PM CEST, Max Reitz <address@hidden> wrote:
After having emptied the cache, the data in the cache tables is no
longer useful, so we can tell the kernel that we are done with it. In
Linux this frees the resources associated with it.
Looks good, but by applying the same logic, you could do the same call
in qcow2_cache_create(). So what about it? :-)
But after qcow2_cache_create() the memory is still unused so this
doesn't have any affect.
That was too easy. Right.
Reviewed-by: Max Reitz <address@hidden>
Also note that bdrv_commit() is used only by the HMP commit operation,
not by QMP commit.
Thanks, I should probably clarify that in the commit message.
[Qemu-devel] [PATCH 2/3] qcow2: add option to clean unused cache entries after some time, Alberto Garcia, 2015/05/18