[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH] blockdev: no need to drain+flush in hmp_drive_del

From: Paolo Bonzini
Subject: [Qemu-devel] [PATCH] blockdev: no need to drain+flush in hmp_drive_del
Date: Thu, 28 May 2015 16:17:09 +0200

bdrv_close already does that, and in fact hmp_drive_del would need
another drain after the flush (which bdrv_close does).  So remove
the duplication.

Signed-off-by: Paolo Bonzini <address@hidden>
 blockdev.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/blockdev.c b/blockdev.c
index 5eaf77e..d506a70 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -2143,9 +2143,6 @@ int hmp_drive_del(Monitor *mon, const QDict *qdict, 
QObject **ret_data)
         return -1;
-    /* quiesce block driver; prevent further io */
-    bdrv_drain_all();
-    bdrv_flush(bs);
     /* if we have a device attached to this BlockDriverState

reply via email to

[Prev in Thread] Current Thread [Next in Thread]