Re: [Qemu-devel] [PATCH v3 0/6] Add Microblaze configuration options

[Edgar E. Iglesias]

On Fri, May 29, 2015 at 04:28:51PM +1000, Alistair Francis wrote:
> Firstly this patch series tidies up some code and removes
> a "xlnx." prefix.
> 
> Then it moves the Microblaze PVR registers to the end
> of the CPUMBState to preserve them during reset. This
> allows most of the operations on them to be moved from
> the reset to the realise. Except for the machine specific
> ones which will be moved when the other properties are
> converted across to standard QEMU props, after this patch
> series is accepted (either merged or the method I'm using
> is approved). See the individual commit for more details.
> 
> Next it adds the "use-stack-protection" property
> to the Microblaze CPU, which allows stack protection to be
> disabled.
> 
> It also converts the previously hardcoded method of enabling
> the FPU to use standard QEMU properties. This simplifies the
> logic in the target-microblaze translate.c.
> 
> V3:
>  - Split disabling stack protection into a seperate patch
>  - Add comments detailing the use-fpu values
> V2:
>  - Small fixes
>  - Disable stack protection by default
>  - Remove the memset and cpu_reset functions from the MB realise
> Changes since RFC:
>  - Preserve the PVR registers during resets
>  - Move most of the logic into realise functions
>  - Small name and function changes

Thanks Alistair,

I've added this into my MicroBlaze queue.

Cheers,
Edgar



> 
> Alistair Francis (6):
>   target-microblaze: Fix up indentation
>   target-microblaze: Preserve the pvr registers during reset
>   target-microblaze: Allow the stack protection to be disabled
>   target-microblaze: Tidy up the base-vectors property
>   target-microblaze: Convert use-fpu to a CPU property
>   target-microblaze: Disable stack protection by default
> 
>  hw/microblaze/petalogix_ml605_mmu.c |    7 +++-
>  target-microblaze/cpu-qom.h         |    9 +++++-
>  target-microblaze/cpu.c             |   60 
> ++++++++++++++++++++++-------------
>  target-microblaze/cpu.h             |   11 ++++--
>  target-microblaze/helper.c          |    8 ++--
>  target-microblaze/op_helper.c       |   10 +++---
>  target-microblaze/translate.c       |   14 +++-----
>  7 files changed, 72 insertions(+), 47 deletions(-)
>