[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 00/20] monitor: Wean core off QError, and oth
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v2 00/20] monitor: Wean core off QError, and other cleanups |
Date: |
Fri, 29 May 2015 10:21:52 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Luiz Capitulino <address@hidden> writes:
> On Tue, 26 May 2015 17:20:35 +0200
> Markus Armbruster <address@hidden> wrote:
>
>> Command handlers still use QError. Left for another day.
>
> Great work! I've found one bug that has to be addressed before merging.
> Also, for the error conversions you're doing you're going from
> qerror_report() to error_set() but I'd recommend going directly to
> error_setg() as that's our final goal. It's totally fine with me
> if you're saving this work for a later series, but I think it will
> you save work if you do it in this series. Your call.
Saving for later, not least because this series has been fully reviewed
now.
> Can you take this through your tree?
Sure!
> Feel free to add this once
> you fix the bug:
>
> Reviewed-by: Luiz Capitulino <address@hidden>
Thanks!
- Re: [Qemu-devel] [PATCH v2 09/20] monitor: Propagate errors through qmp_check_client_args(), (continued)
- [Qemu-devel] [PATCH v2 11/20] monitor: Wean monitor_protocol_emitter() off mon->error, Markus Armbruster, 2015/05/26
- [Qemu-devel] [PATCH v2 17/20] monitor: Drop do_qmp_capabilities()'s superfluous QMP check, Markus Armbruster, 2015/05/26
- [Qemu-devel] [PATCH v2 19/20] monitor: Rename monitor_ctrl_mode() to monitor_is_qmp(), Markus Armbruster, 2015/05/26
- [Qemu-devel] [PATCH v2 07/20] monitor: Use trad. command interface for HMP pcie_aer_inject_error, Markus Armbruster, 2015/05/26
- [Qemu-devel] [PATCH v2 20/20] monitor: Change return type of monitor_cur_is_qmp() to bool, Markus Armbruster, 2015/05/26
- [Qemu-devel] [PATCH v2 15/20] monitor: Rename monitor_control_read(), monitor_control_event(), Markus Armbruster, 2015/05/26
- [Qemu-devel] [PATCH v2 16/20] monitor: Unbox Monitor member mc and rename to qmp, Markus Armbruster, 2015/05/26
- [Qemu-devel] [PATCH v2 18/20] monitor: Turn int command_mode into bool in_command_mode, Markus Armbruster, 2015/05/26
- Re: [Qemu-devel] [PATCH v2 00/20] monitor: Wean core off QError, and other cleanups, Luiz Capitulino, 2015/05/28
- Re: [Qemu-devel] [PATCH v2 00/20] monitor: Wean core off QError, and other cleanups,
Markus Armbruster <=