[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 12/21] monitor: Wean monitor_protocol_emitter() o
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH v3 12/21] monitor: Wean monitor_protocol_emitter() off mon->error |
Date: |
Fri, 29 May 2015 11:56:51 +0200 |
Move mon->error handling to its caller handle_qmp_command().
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Luiz Capitulino <address@hidden>
---
monitor.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/monitor.c b/monitor.c
index d336b8f..56564d5 100644
--- a/monitor.c
+++ b/monitor.c
@@ -407,13 +407,14 @@ static QDict *build_qmp_error_dict(const QError *err)
return qobject_to_qdict(obj);
}
-static void monitor_protocol_emitter(Monitor *mon, QObject *data)
+static void monitor_protocol_emitter(Monitor *mon, QObject *data,
+ QError *err)
{
QDict *qmp;
trace_monitor_protocol_emitter(mon);
- if (!monitor_has_error(mon)) {
+ if (!err) {
/* success response */
qmp = qdict_new();
if (data) {
@@ -425,9 +426,7 @@ static void monitor_protocol_emitter(Monitor *mon, QObject
*data)
}
} else {
/* error response */
- qmp = build_qmp_error_dict(mon->error);
- QDECREF(mon->error);
- mon->error = NULL;
+ qmp = build_qmp_error_dict(err);
}
if (mon->mc->id) {
@@ -5039,8 +5038,10 @@ static void handle_qmp_command(JSONMessageParser
*parser, QList *tokens)
}
err_out:
- monitor_protocol_emitter(mon, data);
+ monitor_protocol_emitter(mon, data, mon->error);
qobject_decref(data);
+ QDECREF(mon->error);
+ mon->error = NULL;
QDECREF(input);
QDECREF(args);
}
--
1.9.3
- [Qemu-devel] [PATCH v3 00/21] monitor: Wean core off QError, and other cleanups, Markus Armbruster, 2015/05/29
- [Qemu-devel] [PATCH v3 02/21] monitor: Clean up after previous commit, Markus Armbruster, 2015/05/29
- [Qemu-devel] [PATCH v3 03/21] monitor: Improve and document client_migrate_info protocol error, Markus Armbruster, 2015/05/29
- [Qemu-devel] [PATCH v3 05/21] monitor: Use traditional command interface for HMP drive_del, Markus Armbruster, 2015/05/29
- [Qemu-devel] [PATCH v3 13/21] monitor: Inline monitor_has_error() into its only caller, Markus Armbruster, 2015/05/29
- [Qemu-devel] [PATCH v3 10/21] monitor: Propagate errors through qmp_check_input_obj(), Markus Armbruster, 2015/05/29
- [Qemu-devel] [PATCH v3 08/21] monitor: Drop unused "new" HMP command interface, Markus Armbruster, 2015/05/29
- [Qemu-devel] [PATCH v3 12/21] monitor: Wean monitor_protocol_emitter() off mon->error,
Markus Armbruster <=
- [Qemu-devel] [PATCH v3 06/21] monitor: Use traditional command interface for HMP device_add, Markus Armbruster, 2015/05/29
- [Qemu-devel] [PATCH v3 11/21] monitor: Propagate errors through invalid_qmp_mode(), Markus Armbruster, 2015/05/29
- Re: [Qemu-devel] [PATCH v3 11/21] monitor: Propagate errors through invalid_qmp_mode(), Eric Blake, 2015/05/29
- [Qemu-devel] [PATCH v3 14/21] monitor: Limit QError use to command handlers, Markus Armbruster, 2015/05/29
- [Qemu-devel] [PATCH v3 15/21] monitor: Rename handle_user_command() to handle_hmp_command(), Markus Armbruster, 2015/05/29