[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/5] net: add missing "netmap" to host_net_devic
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 1/5] net: add missing "netmap" to host_net_devices[] |
Date: |
Fri, 29 May 2015 14:18:16 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, May 27, 2015 at 07:39:17PM +0200, Thomas Huth wrote:
> On Wed, 27 May 2015 17:16:48 +0100
> Stefan Hajnoczi <address@hidden> wrote:
>
> > Although hmp-commands.hx lists "netmap" as a valid host_net_add type,
> > the command rejects it because it's missing from the list.
> >
> > Signed-off-by: Stefan Hajnoczi <address@hidden>
> > ---
> > net/net.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/net/net.c b/net/net.c
> > index db6be12..c5349d2 100644
> > --- a/net/net.c
> > +++ b/net/net.c
> > @@ -58,6 +58,9 @@ const char *host_net_devices[] = {
> > #ifdef CONFIG_NET_BRIDGE
> > "bridge",
> > #endif
> > +#ifdef CONFIG_NETMAP
> > + "netmap",
> > +#endif
> > #ifdef CONFIG_SLIRP
> > "user",
> > #endif
>
> Did you consider to remove it from the help text in hmp-commands.hx
> instead?
> That would force the users to use "netdev_add" for this instead - one
> more reason to get away from the legacy "net" syntax ;-)
There's no reason to artifically limit the command and the intention of
the documentation was clear.
Stefan
pgpsSTOrk7mPY.pgp
Description: PGP signature
- [Qemu-devel] [PATCH 0/5] net: error when -net type isn't compiled in, Stefan Hajnoczi, 2015/05/27
- [Qemu-devel] [PATCH 1/5] net: add missing "netmap" to host_net_devices[], Stefan Hajnoczi, 2015/05/27
- [Qemu-devel] [PATCH 2/5] net: replace net_client_init1() netdev whitelist with blacklist, Stefan Hajnoczi, 2015/05/27
- [Qemu-devel] [PATCH 3/5] net: raise an error if -net type is invalid, Stefan Hajnoczi, 2015/05/27
- [Qemu-devel] [PATCH 5/5] net: simplify net_client_init1(), Stefan Hajnoczi, 2015/05/27
- [Qemu-devel] [PATCH 4/5] net: drop if expression that is always true, Stefan Hajnoczi, 2015/05/27