[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 23/57] machine: Remove unused fields from QEMUMachine
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL 23/57] machine: Remove unused fields from QEMUMachine |
Date: |
Sun, 31 May 2015 20:35:50 +0200 |
From: Eduardo Habkost <address@hidden>
This removes the following fields from QEMUMachine: family, alias,
reset, hot_add_cpu, units_per_default_bus, no_serial, no_parallel,
use_virtcon, use_sclp, no_floppy, no_cdrom, default_display,
compat_props, and hw_version.
The only users of those fields were already converted to use QOM and
MachineClass directly, so they are not needed anymore.
Signed-off-by: Eduardo Habkost <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
include/hw/boards.h | 15 +--------------
vl.c | 15 ---------------
2 files changed, 1 insertion(+), 29 deletions(-)
diff --git a/include/hw/boards.h b/include/hw/boards.h
index 1f11881..ff79797 100644
--- a/include/hw/boards.h
+++ b/include/hw/boards.h
@@ -19,31 +19,18 @@ typedef void QEMUMachineHotAddCPUFunc(const int64_t id,
Error **errp);
typedef int QEMUMachineGetKvmtypeFunc(const char *arg);
struct QEMUMachine {
- const char *family; /* NULL iff @name identifies a standalone machtype */
const char *name;
- const char *alias;
const char *desc;
QEMUMachineInitFunc *init;
- QEMUMachineResetFunc *reset;
- QEMUMachineHotAddCPUFunc *hot_add_cpu;
QEMUMachineGetKvmtypeFunc *kvm_type;
BlockInterfaceType block_default_type;
- int units_per_default_bus;
int max_cpus;
- unsigned int no_serial:1,
- no_parallel:1,
- use_virtcon:1,
- use_sclp:1,
- no_floppy:1,
- no_cdrom:1,
+ unsigned int
no_sdcard:1,
has_dynamic_sysbus:1;
int is_default;
const char *default_machine_opts;
const char *default_boot_order;
- const char *default_display;
- GlobalProperty *compat_props;
- const char *hw_version;
};
void memory_region_allocate_system_memory(MemoryRegion *mr, Object *owner,
diff --git a/vl.c b/vl.c
index 26b1e7e..1d4c089 100644
--- a/vl.c
+++ b/vl.c
@@ -1314,32 +1314,17 @@ static void machine_class_init(ObjectClass *oc, void
*data)
{
MachineClass *mc = MACHINE_CLASS(oc);
QEMUMachine *qm = data;
-
- mc->family = qm->family;
mc->name = qm->name;
- mc->alias = qm->alias;
mc->desc = qm->desc;
mc->init = qm->init;
- mc->reset = qm->reset;
- mc->hot_add_cpu = qm->hot_add_cpu;
mc->kvm_type = qm->kvm_type;
mc->block_default_type = qm->block_default_type;
- mc->units_per_default_bus = qm->units_per_default_bus;
mc->max_cpus = qm->max_cpus;
- mc->no_serial = qm->no_serial;
- mc->no_parallel = qm->no_parallel;
- mc->use_virtcon = qm->use_virtcon;
- mc->use_sclp = qm->use_sclp;
- mc->no_floppy = qm->no_floppy;
- mc->no_cdrom = qm->no_cdrom;
mc->no_sdcard = qm->no_sdcard;
mc->has_dynamic_sysbus = qm->has_dynamic_sysbus;
mc->is_default = qm->is_default;
mc->default_machine_opts = qm->default_machine_opts;
mc->default_boot_order = qm->default_boot_order;
- mc->default_display = qm->default_display;
- mc->compat_props = qm->compat_props;
- mc->hw_version = qm->hw_version;
}
int qemu_register_machine(QEMUMachine *m)
--
MST
- [Qemu-devel] [PULL 13/57] piix: Move pc-0.11 drive version compat props to PC_COMPAT_0_11, (continued)
- [Qemu-devel] [PULL 13/57] piix: Move pc-0.11 drive version compat props to PC_COMPAT_0_11, Michael S. Tsirkin, 2015/05/31
- [Qemu-devel] [PULL 14/57] piix: Move pc-0.13 virtio-9p-pci compat to PC_COMPAT_0_13, Michael S. Tsirkin, 2015/05/31
- [Qemu-devel] [PULL 15/57] piix: Move pc-0.1[23] rombar compat props to PC_COMPAT_0_13, Michael S. Tsirkin, 2015/05/31
- [Qemu-devel] [PULL 16/57] piix: Define PC_COMPAT_0_10, Michael S. Tsirkin, 2015/05/31
- [Qemu-devel] [PULL 17/57] pc: Define MACHINE_OPTIONS macros consistently for all machines, Michael S. Tsirkin, 2015/05/31
- [Qemu-devel] [PULL 18/57] pc: Define machines using a DEFINE_PC_MACHINE macro, Michael S. Tsirkin, 2015/05/31
- [Qemu-devel] [PULL 19/57] pc: Convert *_MACHINE_OPTIONS macros into functions, Michael S. Tsirkin, 2015/05/31
- [Qemu-devel] [PULL 20/57] pc: Move compat_props setting inside *_machine_options() functions, Michael S. Tsirkin, 2015/05/31
- [Qemu-devel] [PULL 21/57] pc: Don't use QEMUMachine anymore, Michael S. Tsirkin, 2015/05/31
- [Qemu-devel] [PULL 22/57] pc: Remove qemu_register_pc_machine() function, Michael S. Tsirkin, 2015/05/31
- [Qemu-devel] [PULL 23/57] machine: Remove unused fields from QEMUMachine,
Michael S. Tsirkin <=
- [Qemu-devel] [PULL 24/57] piix: Add kvmclock_enabled, pci_enabled globals, Michael S. Tsirkin, 2015/05/31
- [Qemu-devel] [PULL 25/57] piix: Eliminate pc_init_pci(), Michael S. Tsirkin, 2015/05/31
- [Qemu-devel] [PULL 27/57] pc: acpi: fix pvpanic for buggy guests, Michael S. Tsirkin, 2015/05/31
- [Qemu-devel] [PULL 26/57] pc: Generate init functions with a macro, Michael S. Tsirkin, 2015/05/31
- [Qemu-devel] [PULL 28/57] virtio: move host_features, Michael S. Tsirkin, 2015/05/31
- [Qemu-devel] [PULL 29/57] virtio-ccw: Don't advertise VIRTIO_F_BAD_FEATURE, Michael S. Tsirkin, 2015/05/31
- [Qemu-devel] [PULL 30/57] virtio: move VIRTIO_F_NOTIFY_ON_EMPTY into core, Michael S. Tsirkin, 2015/05/31
- [Qemu-devel] [PULL 31/57] virtio-net: adding all queues in .realize(), Michael S. Tsirkin, 2015/05/31
- [Qemu-devel] [PULL 32/57] virtio: device_plugged() can fail, Michael S. Tsirkin, 2015/05/31
- [Qemu-devel] [PULL 33/57] virtio: introduce virtio_get_num_queues(), Michael S. Tsirkin, 2015/05/31