Re: [Qemu-devel] fw cfg files cross-version migration races

[Michael S. Tsirkin]

On Tue, Jun 02, 2015 at 09:11:14AM +0200, Gerd Hoffmann wrote:
>   Hi,
> 
> > I guess the only reason this isn't a problem is that nobody currently
> > attempts to access fw_cfg after a migration ? :)
> 
> Accessing fw_cfg after migration is fine.  Problem is this ...
> 
>   (1) read directory
>   (2) migrate
>   (3) read file
> 
> ... in case the file ordering happens to be different on the destination
> host due to initialization order changes.
> 
> So, sorting entries (and the index assigned too) should fix this, right?
> That looks easiest to me.
> 
> cheers,
>   Gerd

Right. The only issue is we are introducing a breakage even if
there was otherwise no reason for it otherwise.
I'll let you make the decision.

-- 
MST