[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Do not fail if id field is present.
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] Do not fail if id field is present. |
Date: |
Fri, 05 Jun 2015 09:43:48 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 06/05/2015 08:17 AM, Pavel Fedin wrote:
> This fixes QMP regression:
> http://lists.gnu.org/archive/html/qemu-devel/2015-06/msg01795.html
>
> Signed-off-by: Pavel Fedin <address@hidden>
> ---
> monitor.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/monitor.c b/monitor.c
> index c7baa91..ef21bba 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -4955,6 +4955,8 @@ static QDict *qmp_check_input_obj(QObject *input_obj,
> Error **errp)
> "arguments", "object");
> return NULL;
> }
> + } else if (!strcmp(arg_name, "id")) {
> + /* Ignored, necessary for backwards compatibility */
I think a better comment would be:
/* Specially handled elsewhere to be included in reply to user */
But I agree that we need something like this patch to avoid a regression
of causing QERR_QMP_EXTRA_MEMBER, since "id" is a documented part of the
protocol.
We also have other patches floating for the same issue:
https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg01488.html
that differ only in the choice of comment.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
Re: [Qemu-devel] [PATCH] Do not fail if id field is present.,
Eric Blake <=