[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4] Use Aff1 with mpidr
|
From: |
Pavel Fedin |
|
Subject: |
Re: [Qemu-devel] [PATCH v4] Use Aff1 with mpidr |
|
Date: |
Mon, 15 Jun 2015 10:13:54 +0300 |
Hello!
> > +int arm_cpus_per_cluster = 8;
>
> This doesn't need to be global, it doesn't need to be exposed in
> a header file, and it definitely doesn't need to be non-constant.
> I suggest
> #define ARM_CPUS_PER_CLUSTER 8
It was a #define in v3, but i decided to change this in order to allow machine
models to request different topology as Igor suggested. Of course you can
revert to #define if you strictly want to.
> These are minor nits so I plan to just fix them as I apply
> this to target-arm.next, unless you object.
No, i don't object and of course i'm waiting for the PULL.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia