qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 08/23] pflash_cfi01: change to new-style MMIO

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v2 08/23] pflash_cfi01: change to new-style MMIO accessors
Date: Wed, 17 Jun 2015 09:56:59 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 

On 09/06/2015 20:08, Richard Henderson wrote:
> > > +    bool be = !!(pfl->features & (1 << PFLASH_BE));
> > >
> > > !!() not needed. Otherwise
> > 
> > I don't like magic bool-ification...
> 
> I don't like !! just as much.  If you don't like implicit conversion, then use
> != 0.

Fair enough, let's add to the coding still that we don't like !!.

Paolo
reply via email to
[Prev in Thread] Current Thread [Next in Thread]