qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-ca


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc
Date: Wed, 17 Jun 2015 21:15:56 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0


On 17/06/2015 20:43, Michael S. Tsirkin wrote:
> It seems pretty obvious:
> 
> +        vmport_rpc = isa_try_create(isa_bus, "vmport_rpc");
> +        if (vmport_rpc) {
> +            qdev_init_nofail(DEVICE(vmport_rpc));
> +        }
> 
> 
> Don't do this. Let user specify the device using -device vmport_rpc.
> Then all issues just go away.  I don't see any reason not to do it like
> this - we should have done the same for other vmport things.

Does it make sense to have an ISA device that has no ports or MMIO
regions?  It's a bit of hack modeling-wise, but sure it works.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]