Re: [Qemu-devel] [PATCH] nvme: Fix memleak in nvme_dma_read_prp

[Stefan Hajnoczi]

On Fri, Jun 19, 2015 at 02:27:34PM +0800, Ting Wang wrote:

Please CC the maintainer of this source file:

  $ scripts/get_maintainer.pl -f hw/block/nvme.c
  Keith Busch <address@hidden> (supporter:nvme)
  Kevin Wolf <address@hidden> (supporter:Block layer core)
  address@hidden (open list:nvme)

> From: Lu Lina <address@hidden>
> 
> Signed-off-by: Lu Lina <address@hidden>

Your Signed-off-by is missing.

> ---
>  hw/block/nvme.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/block/nvme.c b/hw/block/nvme.c
> index 4b6d5e6..c6a6a0e 100644
> --- a/hw/block/nvme.c
> +++ b/hw/block/nvme.c
> @@ -154,6 +154,7 @@ static uint16_t nvme_dma_read_prp(NvmeCtrl *n, uint8_t 
> *ptr, uint32_t len,
>          qemu_sglist_destroy(&qsg);
>          return NVME_INVALID_FIELD | NVME_DNR;
>      }
> +    qemu_sglist_destroy(&qsg);
>      return NVME_SUCCESS;
>  }
>  
> -- 
> 1.8.5
> 
> 
>

pgpv5CLsro_HV.pgp
Description: PGP signature