[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/11] kvm/x86: distingiush hyper-v guest crash
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 09/11] kvm/x86: distingiush hyper-v guest crash notification |
|
Date: |
Tue, 23 Jun 2015 11:52:29 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 23/06/2015 01:55, Peter Hornyack wrote:
>> > -static int kvm_hv_msr_set_crash_ctl(struct kvm_vcpu *vcpu, u64 data)
>> > +static int kvm_hv_msr_set_crash_ctl(struct kvm_vcpu *vcpu, u64 data, bool
>> > host)
>> > {
>> > struct kvm_arch_hyperv *hv = &vcpu->kvm->arch.hyperv;
>> >
>> > hv->hv_crash_ctl = data;
> Should we allow hv_crash_ctl to be set if !host? It's a small detail,
> but it doesn't seem like the guest should be able to disable crash
> actions that userspace has enabled in hv_crash_ctl.
No, the MSR contents shouldn't be writable.
Paolo
- [Qemu-devel] [PATCH 04/11] kvm/x86: added hyper-v crash msrs into kvm hyperv context, (continued)
- [Qemu-devel] [PATCH 04/11] kvm/x86: added hyper-v crash msrs into kvm hyperv context, Denis V. Lunev, 2015/06/22
- [Qemu-devel] [PATCH 08/11] kvm/x86: add sending hyper-v crash notification to user space, Denis V. Lunev, 2015/06/22
- [Qemu-devel] [PATCH 02/11] kvm: introduce vcpu_debug = kvm_debug + vcpu context, Denis V. Lunev, 2015/06/22
- [Qemu-devel] [PATCH 01/11] kvm/x86: move Hyper-V MSR's/hypercall code into hyperv.c file, Denis V. Lunev, 2015/06/22
- [Qemu-devel] [PATCH 10/11] qemu/kvm: kvm hyper-v based guest crash event handling, Denis V. Lunev, 2015/06/22
- [Qemu-devel] [PATCH 09/11] kvm/x86: distingiush hyper-v guest crash notification, Denis V. Lunev, 2015/06/22