qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC] QDev explicit constructors & destructors


From: Andreas Färber
Subject: Re: [Qemu-devel] [RFC] QDev explicit constructors & destructors
Date: Wed, 24 Jun 2015 16:18:39 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0

Am 24.06.2015 um 16:11 schrieb Liviu Ionescu:
> On 24 Jun 2015, at 16:50, Andreas Färber <address@hidden> wrote:
> 
>> You're still doing the {...} thing I asked you not to do.
> 
> thank you for your suggestions.

It's not a suggestion. Our Coding Style is a mandatory requirement for
code review. I already pointed out that it affects readability for those
accustomed to our Coding Style. Instead of you arguing over it I
expected you to acknowledge it and to adapt your code.

> right now I'm more concerned on which APIs to use, and my current 
> understanding is that you prefer direct QOM calls over QDev, which are 
> deprecated. is this correct?
> 
> regarding the layout of my code, I did not make a final decision yet, but it 
> might very well be C++, with some wrappers over your QOM objects.

First, they're not "my" QOM objects. I did not invent it.

Second, we are certainly not going to let every contributor, especially
not new ones, make their own choices of programming language inside our
code base. QOM was not just a transitory tool, some people here (not me)
were and are against C++, which currently is optional for AArch64
disassembler.

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB
21284 (AG Nürnberg)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]