[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 10/10] hw/pci-bridge: format special OFW unit
From: |
Kevin O'Connor |
Subject: |
Re: [Qemu-devel] [PATCH v7 10/10] hw/pci-bridge: format special OFW unit address for PXB host |
Date: |
Wed, 24 Jun 2015 13:11:12 -0400 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Fri, Jun 19, 2015 at 04:40:17AM +0200, Laszlo Ersek wrote:
> We have agreed that OpenFirmware device paths in the "bootorder" fw_cfg
> file should follow the pattern
>
> /address@hidden,%x/...
>
> for devices that live behind an extra root bus. The extra root bus in
> question is the %x'th among the extra root buses. (In other words, %x
> gives the position of the affected extra root bus relative to the other
> extra root buses, in bus_nr order.) %x starts at 1, and is formatted in
> hex.
>
> The portion of the unit address that comes before the comma is dynamically
> taken from the main host bridge, similarly to sysbus_get_fw_dev_path().
>
> Cc: Kevin O'Connor <address@hidden>
> Cc: Michael S. Tsirkin <address@hidden>
> Cc: Marcel Apfelbaum <address@hidden>
> Signed-off-by: Laszlo Ersek <address@hidden>
> ---
>
> Notes:
> v7:
> - implement the format that both Kevin and Michael agreed with. Example:
>
> /address@hidden,1/address@hidden/address@hidden/address@hidden/address@hidden,0
> - I updated the OVMF patchset accordingly, but I won't post it until
> this QEMU patch is applied
> - Someone please write the SeaBIOS patch
The associated SeaBIOS patch is below.
Does anyone have a qemu command line handy to test with the PXB bus?
-Kevin
--- a/src/boot.c
+++ b/src/boot.c
@@ -112,9 +112,9 @@ build_pci_path(char *buf, int max, const char *devname,
struct pci_device *pci)
if (pci->parent) {
p = build_pci_path(p, max, "pci-bridge", pci->parent);
} else {
- if (pci->rootbus)
- p += snprintf(p, max, "/address@hidden", pci->rootbus);
p += snprintf(p, buf+max-p, "%s", FW_PCI_DOMAIN);
+ if (pci->rootbus)
+ p += snprintf(p, buf+max-p, ",%x", pci->rootbus);
}
int dev = pci_bdf_to_dev(pci->bdf), fn = pci_bdf_to_fn(pci->bdf);
- [Qemu-devel] [PATCH v7 05/10] hw/pci: introduce shpc_present() helper function, (continued)
- [Qemu-devel] [PATCH v7 05/10] hw/pci: introduce shpc_present() helper function, Laszlo Ersek, 2015/06/18
- [Qemu-devel] [PATCH v7 04/10] hw/pci-bridge: add macro for "msi" property, Laszlo Ersek, 2015/06/18
- [Qemu-devel] [PATCH v7 06/10] hw/pci-bridge: introduce "shpc" property, Laszlo Ersek, 2015/06/18
- [Qemu-devel] [PATCH v7 07/10] hw/pci-bridge: disable SHPC in PXB, Laszlo Ersek, 2015/06/18
- [Qemu-devel] [PATCH v7 08/10] hw/core: rebase sysbus_get_fw_dev_path() to g_strdup_printf(), Laszlo Ersek, 2015/06/18
- [Qemu-devel] [PATCH v7 09/10] hw/core: explicit OFW unit address callback for SysBusDeviceClass, Laszlo Ersek, 2015/06/18
- [Qemu-devel] [PATCH v7 10/10] hw/pci-bridge: format special OFW unit address for PXB host, Laszlo Ersek, 2015/06/18
- Re: [Qemu-devel] [PATCH v7 10/10] hw/pci-bridge: format special OFW unit address for PXB host,
Kevin O'Connor <=