Re: [Qemu-devel] [PATCH 0/4] virtio-ccw: virtio-1 enablement

[Cornelia Huck]

On Thu, 25 Jun 2015 14:49:00 +0200
"Michael S. Tsirkin" <address@hidden> wrote:

> On Thu, Jun 25, 2015 at 12:24:40PM +0200, Cornelia Huck wrote:

> > On a second thought, I can simply include dev->revision, as we have the
> > incompatible ->config_vector change for this release already. I'll
> > include a new patch for this and patch 4 as well, as we only need to
> > care about Linux guests on ccw for now and those are fine.
> 
> I don't think enable by default is a good idea for 2.4 since
> I think we have spec compliance issues which just don't
> trigger with linux guests. For example, devices poke at
> rings before DRIVER_OK is set.
> 
> If we release QEMU like this, guests will have to work
> around these issues, which is not nice.
> Let's release 2.4 in disabled by default mode, and flip
> it around for 2.5.

If you put it that way, I agree to defer the actual enablement. I'll
keep the ->revision migration patch, though.