Re: [Qemu-devel] [PATCH v6 0/6] Memory hotplug for PowerPC sPAPR guests

[David Gibson]

On Mon, Jun 29, 2015 at 02:14:26PM +0530, Bharata B Rao wrote:
> Hi,
> 
> This is v5 of memory hotplug support patchset for PowerPC
> sPAPR guests.
> 
> This patchset applies on spapr-next branch of David Gibson's tree with
> pc_dimm_pug reorg+NUMA node lookup patchset v4:
> http://lists.nongnu.org/archive/html/qemu-devel/2015-06/msg07174.html

Looking good.  I'd like to pull this into spapr-next, but I'll need to
wait for the pc_dimm_plug rework to be merged.  Do you know whose tree
that's likely to go via?

> 
> Changes in v6
> -------------
> - Rebased on top of latest pc_dimm_reorg+NUMA node lookup patchset v4.
> - Instead of silently disabling memory hotplug, refuse to boot with memory
>   configurations where RAM size or maxmem size or node memory size isn't
>   aligned to SPAPR_MEMORY_BLOCK_SIZE(256MB). (2/6)
> - Pushed a recoverable error check (hotplug mem size not aligned to 256MB)
>   from spapr_add_lmbs() down to spapr_memory_plug() so that we can
>   pass error_abort to spapr_add_lmbs() and let it abort in case of errors.
>   This is in line with Igor's observation that we shouldn't fail and hence
>   shouldn't try recovery after we have done guest visible changes. (5/6)
> 
> v5: http://lists.nongnu.org/archive/html/qemu-ppc/2015-06/msg00267.html
> v4: https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg05242.html
> v3: https://lists.nongnu.org/archive/html/qemu-devel/2015-04/msg02910.html
> 
> Bharata B Rao (6):
>   spapr: Initialize hotplug memory address space
>   spapr: Add LMB DR connectors
>   spapr: Support ibm,dynamic-reconfiguration-memory
>   spapr: Make hash table size a factor of maxram_size
>   spapr: Memory hotplug support
>   spapr: Don't allow memory hotplug to memory less nodes
> 
>  default-configs/ppc64-softmmu.mak |   1 +
>  docs/specs/ppc-spapr-hotplug.txt  |  48 ++++
>  hw/ppc/spapr.c                    | 458 
> ++++++++++++++++++++++++++++++++++----
>  hw/ppc/spapr_events.c             |   8 +-
>  hw/ppc/spapr_hcall.c              |  51 ++++-
>  include/hw/ppc/spapr.h            |  28 ++-
>  6 files changed, 540 insertions(+), 54 deletions(-)
> 

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

pgpHekl_nLEFY.pgp
Description: PGP signature