[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [SeaBIOS] [PATCH v2 02/22] virtio: run drivers in 32bit
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [SeaBIOS] [PATCH v2 02/22] virtio: run drivers in 32bit mode |
Date: |
Wed, 01 Jul 2015 09:27:12 +0200 |
On Di, 2015-06-30 at 10:36 -0400, Kevin O'Connor wrote:
> On Tue, Jun 30, 2015 at 10:38:53AM +0200, Gerd Hoffmann wrote:
> > virtio version 1.0 registers can (and actually do in the qemu
> > implementation) live in mmio space. So we must run the blk and
> > scsi virtio drivers in 32bit mode, otherwise we can't access them.
> >
> > This also allows to drop a bunch of GET_LOWFLAT calls from the virtio
> > code in the following patches.
>
> I think this patch is missing a "if (!MODESEGMENT)" check in
> src/hw/blockcmd.c - otherwise the virtio scsi code will still be
> included in the 16bit section.
>
> Also, this patch (or a follow up patch) should update the Makefile to
> not compile the virtio code in 16bit mode.
Both fixed.
cheers,
Gerd
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [SeaBIOS] [PATCH v2 02/22] virtio: run drivers in 32bit mode,
Gerd Hoffmann <=