[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 04/17] blockdev: no need to drain+flush in hmp_drive_
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PULL 04/17] blockdev: no need to drain+flush in hmp_drive_del |
Date: |
Thu, 2 Jul 2015 10:19:36 +0100 |
From: Paolo Bonzini <address@hidden>
bdrv_close already does that, and in fact hmp_drive_del would need
another drain after the flush (which bdrv_close does). So remove
the duplication.
Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
blockdev.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index b354676..4d5e016 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -2167,9 +2167,6 @@ void hmp_drive_del(Monitor *mon, const QDict *qdict)
return;
}
- /* quiesce block driver; prevent further io */
- bdrv_drain_all();
- bdrv_flush(bs);
bdrv_close(bs);
/* if we have a device attached to this BlockDriverState
--
2.4.3
- [Qemu-devel] [PULL 00/17] Block patches, Stefan Hajnoczi, 2015/07/02
- [Qemu-devel] [PULL 01/17] block/iscsi: add support for request timeouts, Stefan Hajnoczi, 2015/07/02
- [Qemu-devel] [PULL 02/17] qcow2: Handle EAGAIN returned from update_refcount, Stefan Hajnoczi, 2015/07/02
- [Qemu-devel] [PULL 03/17] qapi: Rename 'dirty-bitmap' mode to 'incremental', Stefan Hajnoczi, 2015/07/02
- [Qemu-devel] [PULL 04/17] blockdev: no need to drain+flush in hmp_drive_del,
Stefan Hajnoczi <=
- [Qemu-devel] [PULL 05/17] timer: Move NANOSECONDS_PER_SECONDS to timer.h, Stefan Hajnoczi, 2015/07/02
- [Qemu-devel] [PULL 06/17] timer: Use a single definition of NSEC_PER_SEC for the whole codebase, Stefan Hajnoczi, 2015/07/02
- [Qemu-devel] [PULL 07/17] block: Add bdrv_get_block_status_above, Stefan Hajnoczi, 2015/07/02
- [Qemu-devel] [PULL 08/17] qmp: Add optional bool "unmap" to drive-mirror, Stefan Hajnoczi, 2015/07/02
- [Qemu-devel] [PULL 09/17] mirror: Do zero write on target if sectors not allocated, Stefan Hajnoczi, 2015/07/02
- [Qemu-devel] [PULL 10/17] block: Fix dirty bitmap in bdrv_co_discard, Stefan Hajnoczi, 2015/07/02
- [Qemu-devel] [PULL 11/17] block: Remove bdrv_reset_dirty, Stefan Hajnoczi, 2015/07/02
- [Qemu-devel] [PULL 12/17] qemu-iotests: Make block job methods common, Stefan Hajnoczi, 2015/07/02
- [Qemu-devel] [PULL 13/17] qemu-iotests: Add test case for mirror with unmap, Stefan Hajnoczi, 2015/07/02
- [Qemu-devel] [PULL 14/17] iotests: Use event_wait in wait_ready, Stefan Hajnoczi, 2015/07/02