Re: [Qemu-devel] [PATCH v4 2/9] Implement GIC-500

[Peter Maydell]

On 2 July 2015 at 15:14, Pavel Fedin <address@hidden> wrote:
> From: Shlomo Pongratz <address@hidden>
>
> Implement GIC-500 from GICv3 family for arm64
>
> This patch is a first step toward 128 cores support for arm64.
>
> At first only 64 cores are supported for two reasons:
> First the largest integer type has the size of 64 bits and modifying
> essential data structures in order to support 128 cores will require
> the usage of bitops.
> Second currently the Linux (kernel) can be configured to support
> up to 64 cores thus there is no urgency with 128 cores support.
>
> Signed-off-by: Shlomo Pongratz <address@hidden>
> ---
>  hw/intc/Makefile.objs |    1 +
>  hw/intc/arm_gicv3.c   | 2086 
> +++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 2087 insertions(+)
>  create mode 100644 hw/intc/arm_gicv3.c

Hi. I'm afraid 2000 lines is really far too many to review as
a single patch. Please split this one up into more digestible
chunks.

thanks
-- PMM