|
From: | Markus Armbruster |
Subject: | Re: [Qemu-devel] [PATCH] block: update bdrv_drain_all()/bdrv_drain() comments |
Date: | Fri, 03 Jul 2015 14:49:18 +0200 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Stefan Hajnoczi <address@hidden> writes: > The doc comments for bdrv_drain_all() and bdrv_drain() are outdated: > > * The bdrv_drain() comment is a poor man's bdrv_lock()/bdrv_unlock() > which Fam Zheng is currently developing. Unfortunately this warning > was never really enough because devices keep submitting I/O and op > blockers don't prevent that. > > * The bdrv_drain_all() comment is still partially correct but reflects > the nature of the implementation rather than API documentation. > > Do make it clear that bdrv_drain() is only appropriate within an > AioContext. For anything spanning AioContexts you need > bdrv_drain_all(). > > Cc: Markus Armbruster <address@hidden> > Cc: Paolo Bonzini <address@hidden> > Signed-off-by: Stefan Hajnoczi <address@hidden> For what it's worth (I'm not deep into our AIO): Reviewed-by: Markus Armbruster <address@hidden>
[Prev in Thread] | Current Thread | [Next in Thread] |