[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] QOM: object_property_add() performance impro
|
From: |
Pavel Fedin |
|
Subject: |
Re: [Qemu-devel] [PATCH v3] QOM: object_property_add() performance improvement |
|
Date: |
Fri, 03 Jul 2015 16:38:53 +0300 |
Hello! Thank you very much for your feedback.
> Nack, I don't like the patch as is. Starting with the unoptimized code
> movement combined with functional changes
Will it be OK if i split it into two parts:
1. Restructuring, introduction of object_property_add_single()
2. Introduction of cache property by itself.
> up to the use of [*] for the
> new property iiuc.
What would you suggest instead? Personally i don't have much preferences, i
used it just because it was already there.
What about 'name#' ?
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia