Re: [Qemu-devel] [PATCH v9 09/20] i.MX: Remove Qdev EPIT construction helper function.

[Peter Crosthwaite]

On Sat, Jul 4, 2015 at 7:34 AM, Jean-Christophe Dubois
<address@hidden> wrote:
> Signed-off-by: Jean-Christophe Dubois <address@hidden>
> ---
>
> Changes since v1:
>     * not present on v1
>
> Changes since v2:
>     * not present on v2
>
> Changes since v3:
>     * not present on v3
>
> Changes since v4:
>     * not present on v4
>
> Changes since v5:
>     * not present on v5
>
> Changes since v6:
>     * not present on v6
>
> Changes since v7:
>     * not present on v7
>
> Changes since v8:
>     * remove qdev construction helper
>
>  hw/timer/imx_epit.c  | 11 -----------
>  include/hw/arm/imx.h |  3 ---
>  2 files changed, 14 deletions(-)
>
> diff --git a/hw/timer/imx_epit.c b/hw/timer/imx_epit.c
> index f1f82e9..68dc0bc 100644
> --- a/hw/timer/imx_epit.c
> +++ b/hw/timer/imx_epit.c
> @@ -12,7 +12,6 @@
>   *
>   */
>
> -#include "hw/arm/imx.h"
>  #include "hw/timer/imx_epit.h"
>  #include "hw/misc/imx_ccm.h"
>  #include "qemu/main-loop.h"
> @@ -287,16 +286,6 @@ static void imx_epit_cmp(void *opaque)
>      imx_epit_update_int(s);
>  }
>
> -void imx_timerp_create(const hwaddr addr, qemu_irq irq, DeviceState *ccm)
> -{
> -    IMXEPITState *pp;
> -    DeviceState *dev;
> -
> -    dev = sysbus_create_simple(TYPE_IMX_EPIT, addr, irq);
> -    pp = IMX_EPIT(dev);
> -    pp->ccm = ccm;
> -}
> -
>  static const MemoryRegionOps imx_epit_ops = {
>    .read = imx_epit_read,
>    .write = imx_epit_write,
> diff --git a/include/hw/arm/imx.h b/include/hw/arm/imx.h
> index 6cb90cc..5073c06 100644
> --- a/include/hw/arm/imx.h
> +++ b/include/hw/arm/imx.h
> @@ -11,9 +11,6 @@
>  #ifndef IMX_H
>  #define IMX_H
>
> -void imx_timerp_create(const hwaddr addr,
> -                      qemu_irq irq,
> -                      DeviceState *ccm);

This de-features this API, but the use in kzm.c is not removed until
P15. This probably breaks the build. I suggest on your series you use
git rev-list on your patch range and loop over it with git checkout &
do a build to build-test all the in-between revisions in the series.
It is also a good idea to run make check in the same fashion.

I use something like this myself:

#!/bin/bash

make distclean
set -e
./configure ...
for I in $(git rev-list ...); do
    git checkout $I;
    make -j:
    make check;
done

It will be slow, I speed it up by dropping make check and doing that
once at the end once I think I'm ready to send. Don't forget to return
to your branch after running the script as it will detach git from
your working branch.

Regards,
Peter

>  void imx_timerg_create(const hwaddr addr,
>                        qemu_irq irq,
>                        DeviceState *ccm);
> --
> 2.1.4
>
>