[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 18/19] Stop including qemu-common.h in memory.h
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PULL 18/19] Stop including qemu-common.h in memory.h |
Date: |
Mon, 6 Jul 2015 14:02:35 +0100 |
On 6 July 2015 at 13:35, Paolo Bonzini <address@hidden> wrote:
> From: Peter Maydell <address@hidden>
> --- /dev/null
> +++ b/include/qemu/fprintf-fn.h
> @@ -0,0 +1,16 @@
> +/*
> + * Typedef for fprintf-alike function pointers.
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2 or later.
> + * See the COPYING file in the top-level directory.
> + */
> +
> +#ifndef FPRINTF_FN_H
Whoops. There should be a
#define FPRINTF_FN_H
here... (gcc doesn't complain about the redefinition of the typedef,
but clang does.)
> +
> +#include "qemu/compiler.h"
> +#include <stdio.h>
> +
> +typedef int (*fprintf_function)(FILE *f, const char *fmt, ...)
> + GCC_FMT_ATTR(2, 3);
> +
> +#endif
thanks & apologies
-- PMM
- [Qemu-devel] [PULL 09/19] main-loop: use qemu_mutex_lock_iothread consistently, (continued)
- [Qemu-devel] [PULL 09/19] main-loop: use qemu_mutex_lock_iothread consistently, Paolo Bonzini, 2015/07/06
- [Qemu-devel] [PULL 11/19] memory: Add global-locking property to memory regions, Paolo Bonzini, 2015/07/06
- [Qemu-devel] [PULL 12/19] exec: pull qemu_flush_coalesced_mmio_buffer() into address_space_rw/ld*/st*, Paolo Bonzini, 2015/07/06
- [Qemu-devel] [PULL 13/19] memory: let address_space_rw/ld*/st* run outside the BQL, Paolo Bonzini, 2015/07/06
- [Qemu-devel] [PULL 10/19] main-loop: introduce qemu_mutex_iothread_locked, Paolo Bonzini, 2015/07/06
- [Qemu-devel] [PULL 15/19] kvm: Switch to unlocked PIO, Paolo Bonzini, 2015/07/06
- [Qemu-devel] [PULL 14/19] kvm: First step to push iothread lock out of inner run loop, Paolo Bonzini, 2015/07/06
- [Qemu-devel] [PULL 16/19] acpi: mark PMTIMER as unlocked, Paolo Bonzini, 2015/07/06
- [Qemu-devel] [PULL 19/19] exec: skip MMIO regions correctly in cpu_physical_memory_write_rom_internal, Paolo Bonzini, 2015/07/06
- [Qemu-devel] [PULL 18/19] Stop including qemu-common.h in memory.h, Paolo Bonzini, 2015/07/06
- Re: [Qemu-devel] [PULL 18/19] Stop including qemu-common.h in memory.h,
Peter Maydell <=
- [Qemu-devel] [PULL 17/19] kvm: Switch to unlocked MMIO, Paolo Bonzini, 2015/07/06