[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL v2 00/13] KVM patches (SMM implementation) for 20
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PULL v2 00/13] KVM patches (SMM implementation) for 2015-07-06 |
Date: |
Mon, 6 Jul 2015 18:40:51 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 |
On 06/07/2015 18:31, Peter Maydell wrote:
> I'm afraid this doesn't build on OSX or on ARM Linux
> (or likely any build host where x86 isn't a CONFIG_KVM build):
>
> CC i386-softmmu/hw/i386/pc_piix.o
> /Users/pm215/src/qemu/hw/i386/pc.c:1782:56: error: use of undeclared
> identifier
> 'KVM_CAP_X86_SMM'
> smm_available = kvm_check_extension(kvm_state, KVM_CAP_X86_SMM);
> ^
> 1 error generated.
>
> Putting #ifdef CONFIG_KVM around the offending line fixes this;
> there may be a cleaner approach.
Indeed the same file already does something cleaner for
kvm_allows_irq0_override().
Paolo