[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH V6 18/18] translate-all: (wip) use tb_flush_
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [RFC PATCH V6 18/18] translate-all: (wip) use tb_flush_safe when we can't alloc more tb. |
Date: |
Tue, 07 Jul 2015 17:17:54 +0100 |
address@hidden writes:
> From: KONRAD Frederic <address@hidden>
>
> This changes just the tb_flush called from tb_alloc.
>
> TODO:
> * changes the other tb_flush.
>
> Signed-off-by: KONRAD Frederic <address@hidden>
> ---
> translate-all.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/translate-all.c b/translate-all.c
> index 8bd8fe8..9adaffa 100644
> --- a/translate-all.c
> +++ b/translate-all.c
> @@ -1147,7 +1147,7 @@ TranslationBlock *tb_gen_code(CPUState *cpu,
> tb = tb_alloc(pc);
> if (!tb) {
> /* flush must be done */
> - tb_flush(env);
> + tb_flush_safe(env);
Hold on this is async right? What stops us rolling on and then getting
flushed when the other vCPUs come to a halt?
It deserves a comment at least.
> /* cannot fail at this point */
> tb = tb_alloc(pc);
> /* Don't forget to invalidate previous TB info. */
--
Alex Bennée
- Re: [Qemu-devel] [RFC PATCH V6 18/18] translate-all: (wip) use tb_flush_safe when we can't alloc more tb.,
Alex Bennée <=