Re: [Qemu-devel] [PATCH] qga: fix build for older versions of mingw

[Denis V. Lunev]

On 07/07/15 20:13, Olga Krishtal wrote:
> Peter, can you try this patch on your system?
>
> In mingw older than mingw64-headers-4.0.2-1.el7.noarch
> header ntddscsi.h can be found in include/ddk, however
> compiler does not look there. This breaks the compilation.
>
> The patch adds this directory in QEMU_INCLUDES.
>
> Signed-off-by: Olga Krishtal <address@hidden>
> ---
>   configure | 9 ++++++++-
>   1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 52cfe18..ada8895 100755
> --- a/configure
> +++ b/configure
> @@ -3763,7 +3763,6 @@ if test "$usb_redir" != "no" ; then
>           usb_redir="no"
>       fi
>   fi
> -
>   ##########################################
>   # check if we have VSS SDK headers for win
>
> @@ -3820,6 +3819,14 @@ if test "$mingw32" = "yes" -a "$guest_agent" != "no" -a 
> "$guest_agent_with_vss"
>   fi
>
>   ##########################################
> +# mingw package on Linux is quite different with different versions. ntddscsi.h
> +# can be found sys-root/mingw/include and in sys-root/mingw/include/ddk
> +# Add ddk directory to lookup path automatically
> +if test "$mingw32" = "yes" -a "$guest_agent" != "no"; then
> +  QEMU_INCLUDES="$QEMU_INCLUDES -I`$cc -print-sysroot`/mingw/include/ddk"
> +fi
> +
> +##########################################
>   # Guest agent Window MSI  package
>
>   if test "$guest_agent" != yes; then

actually this is a dirty hack, but we want to
know whether additional include directory help or not.
If this helps, we could think how to avoid extra
configuration option and ifdef in the code.

Den