qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5] vhost-user: add multi queue support


From: Michael S. Tsirkin
Subject: Re: [Qemu-devel] [PATCH v5] vhost-user: add multi queue support
Date: Wed, 8 Jul 2015 17:29:11 +0300

On Thu, May 28, 2015 at 09:23:06AM +0800, Ouyang Changchun wrote:
> Based on patch by Nikolay Nikolaev:
> Vhost-user will implement the multi queue support in a similar way
> to what vhost already has - a separate thread for each queue.
> To enable the multi queue functionality - a new command line parameter
> "queues" is introduced for the vhost-user netdev.
> 
> Signed-off-by: Nikolay Nikolaev <address@hidden>
> Signed-off-by: Changchun Ouyang <address@hidden>

So testing turned up a significant issue with the protocol extension in this
one.  Specifically, remote has no idea how many queues guest actually
wants to use (it's dynamic, guest changes this at any time).
We need support for enabling and disabling queues dynamically.

Given we are past hard freeze, and given no one uses this yet
(dpdk upstream did not merge supporting protocol),
I think the best thing to do is to disable this functionality for 2.4.
I will send a patch to do this shortly.

I do think this support is important, so me and Marcel will try work on
it in the coming several weeks, and to come up with a better protocol.
I hope we'll be able to have a replacement ready by the time 2.4
is released and 2.5 development opens up so it can be merged first
thing.

It also seems that it will also align better with the plans to use this
in upstream dpdk.

-- 
MST



reply via email to

[Prev in Thread] Current Thread [Next in Thread]