[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for 2.4 1/2] tcg/mips: Fix build error from merg
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH for 2.4 1/2] tcg/mips: Fix build error from merged memop+mmu_idx parameter |
Date: |
Thu, 9 Jul 2015 15:58:03 +0200 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On 2015-07-09 10:17, James Hogan wrote:
> Commit 3972ef6f830d ("tcg: Push merged memop+mmu_idx parameter to
> softmmu routines") caused the following build errors when building TCG
> for MIPS:
>
> In file included from tcg/tcg.c:258:0:
> tcg/mips/tcg-target.c In function ‘tcg_out_qemu_ld_slow_path’:
> tcg/mips/tcg-target.c:1015:22: error: ‘lb’ undeclared (first use in this
> function)
> tcg/mips/tcg-target.c In function ‘tcg_out_qemu_st_slow_path’:
> tcg/mips/tcg-target.c:1058:22: error: ‘lb’ undeclared (first use in this
> function)
>
> It looks like lb was meant to refer to the TCGLabelQemuLdst *l
> parameter, so fix both references to lb to refer to just l.
>
> Fixes: 3972ef6f830d ("tcg: Push merged memop+mmu_idx parameter to softmmu
> routines")
> Signed-off-by: James Hogan <address@hidden>
> Cc: Aurelien Jarno <address@hidden>
> Cc: Leon Alrae <address@hidden>
> Cc: Richard Henderson <address@hidden>
> Cc: Peter Maydell <address@hidden>
> ---
> tcg/mips/tcg-target.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by: Aurelien Jarno <address@hidden>
I was planning to test various hosts after the rc0 release, but it seems
you have been faster. Unfortunately we have more regressions, I am going
to send some more mails.
I am fine if it can be merged directly.
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
address@hidden http://www.aurel32.net