[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5] target-i386: Register QOM properties for fea
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [Qemu-devel] [PATCH v5] target-i386: Register QOM properties for feature flags |
|
Date: |
Thu, 9 Jul 2015 11:51:55 -0300 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, Jul 09, 2015 at 04:15:19PM +0200, Paolo Bonzini wrote:
>
>
> On 14/04/2015 17:28, Eduardo Habkost wrote:
> > + for (i = 1; names[i]; i++) {
> > + feat2prop(names[i]);
> > + object_property_add_alias(obj, names[i], obj, names[0],
> > &error_abort);
>
> The version you committed has a strdup(names[0]) here, but
> object_property_add_alias already does a strdup.
object_property_add_alias() didn't have a strdup() on June 2. I sent a
note about it at:
Date: Fri, 22 May 2015 16:13:55 -0300
From: Eduardo Habkost <address@hidden>
To: address@hidden
Message-ID: <address@hidden>
Subject: Re: [Qemu-devel] [PATCH v5] target-i386: Register QOM properties for
feature flags
Now that the object_property_add_alias() patch was merged, we can remove
hte g_strdup() call.
--
Eduardo